-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] [bidi] Simplify type naming of internal command parameters #16188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] [bidi] Simplify type naming of internal command parameters #16188
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||||||||
|
CI format failure is not relates to these changes, @cgoldberg please check 706495a |
I just fixed it it trunk. It was a whitespace change I couldn't see in the PR, and I got a little trigger happy with merging before CI ran :) |
User description
Simplify type naming of internal command parameters
💥 What does this PR do?
Rename internal classes to see less code, aligned with specification type names.
🔄 Types of changes
PR Type
Other
Description
Rename internal command parameter classes for brevity
Remove "Command" prefix from parameter type names
Simplify base class names from CommandOptions to Options
Update all BiDi module command implementations consistently
Diagram Walkthrough
File Walkthrough
52 files
Update parameter type referencesRename base classesRename parameter and options classesUpdate base class namesUpdate base class namesRename parameter and options classesRename parameter and options classesUpdate all parameter type referencesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesUpdate method parameter typesRename base parameter classesRename class from CommandOptions to OptionsUpdate parameter type referencesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesUpdate base class and optionsRename parameter and options classesUpdate all parameter type referencesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter classRename parameter and options classesRename parameter and options classesRename parameter and options classesUpdate parameter type referencesUpdate base class namesRename parameter and options classesUpdate parameter type referencesUpdate base class namesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesRename parameter and options classesUpdate parameter type references